Set provided name on transforms with side outputs #4779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4779 +/- ##
==========================================
+ Coverage 61.08% 61.10% +0.01%
==========================================
Files 286 286
Lines 10555 10558 +3
Branches 771 768 -3
==========================================
+ Hits 6448 6451 +3
Misses 4107 4107
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
RustedBones
force-pushed
the
side-output-name
branch
from
f453e1d
to
519663d
Compare
RustedBones
commented
Apr 13, 2023
Comment on lines
-35
to
-36
| val internal: PCollection[T], | ||
| val context: ScioContext, |
There was a problem hiding this comment.
This is a breaking change.
We need to have access to the Scollecction to get the name. The new definition is consistent with other SCollection wrapper
RustedBones
requested review from
a team and
jjengo
and removed request for
a team
farzad-sedghi
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4777
Do not run scio context when only asserting on names to speedup testing